Fix Team Race duplicate-membership bug and two related team-roster gaps
Reported by the user: creating a team, adding the wrong driver, then moving that driver to another team by ticking them on the new team's edit form left the driver on both teams at once. Root cause: there was never a "move" action - the edit form only ever added a driver to the team being saved, never removed them from wherever they already were. Live laps from a driver on two teams were then silently credited to only the first-matching team, with no clear error. reassignTeamMembers (event_race_logic.js) now strips a driver/car being saved onto one team out of every other team in the same event, and the team checkbox list shows which team a driver is already on before you move them. Also fixed two related gaps found while investigating, at the user's request to fix everything: getTeamDriverPool had regressed to ignoring the event's class/participant scoping entirely (showing every driver in the club), and deleting a driver or car left them behind in team rosters forever. Added a duplicate_team_members Race Day preflight check as defense in depth for any already-corrupted saved state. Verified with new unit tests for reassignTeamMembers, getTeamDriverPool and the new preflight check, plus a new permanent browser test reproducing the user's exact reported scenario end to end. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
71b3451b13
commit
15b574a37d
16 files changed
+261
-15
No files matched your search
@@ -104,6 +104,17 @@ export function buildRaceDayPreflight(state, session, { backendAvailable = false
|
||||
const missingCount = teamTransponders.filter((values) => !values.length).length;
|
||||
transponders = teamTransponders.flat();
|
||||
checks.push(check("transponders", missingCount ? "error" : "ok", { count: transponders.length, missingCount, teamRace: true }));
|
||||
// Named explicitly rather than relying on the transponder-duplicate check below to
|
||||
// catch this indirectly: that check only fires when the shared driver/car has a
|
||||
// transponder set, and reports "duplicate transponders" - a confusing diagnosis for
|
||||
// what is actually "this driver/car is on two teams at once".
|
||||
const duplicateTeamDriverIds = duplicateValues(teams.flatMap((team) => team.driverIds || []));
|
||||
const duplicateTeamCarIds = duplicateValues(teams.flatMap((team) => team.carIds || []));
|
||||
const duplicateTeamMemberNames = [
|
||||
...duplicateTeamDriverIds.map((id) => state.drivers.find((driver) => driver.id === id)?.name).filter(Boolean),
|
||||
...duplicateTeamCarIds.map((id) => state.cars.find((car) => car.id === id)?.name).filter(Boolean),
|
||||
];
|
||||
checks.push(check("duplicate_team_members", duplicateTeamMemberNames.length ? "error" : "ok", { duplicateTeamMemberNames }));
|
||||
} else {
|
||||
entrantIds = getRaceDriverIds(state, session, event);
|
||||
checks.push(check("participants", entrantIds.length ? "ok" : "error", { count: entrantIds.length }));
|
||||
|
||||
Reference in new issue
Block a user