Fix Team Race duplicate-membership bug and two related team-roster gaps
Reported by the user: creating a team, adding the wrong driver, then moving that driver to another team by ticking them on the new team's edit form left the driver on both teams at once. Root cause: there was never a "move" action - the edit form only ever added a driver to the team being saved, never removed them from wherever they already were. Live laps from a driver on two teams were then silently credited to only the first-matching team, with no clear error. reassignTeamMembers (event_race_logic.js) now strips a driver/car being saved onto one team out of every other team in the same event, and the team checkbox list shows which team a driver is already on before you move them. Also fixed two related gaps found while investigating, at the user's request to fix everything: getTeamDriverPool had regressed to ignoring the event's class/participant scoping entirely (showing every driver in the club), and deleting a driver or car left them behind in team rosters forever. Added a duplicate_team_members Race Day preflight check as defense in depth for any already-corrupted saved state. Verified with new unit tests for reassignTeamMembers, getTeamDriverPool and the new preflight check, plus a new permanent browser test reproducing the user's exact reported scenario end to end. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
71b3451b13
commit
15b574a37d
16 files changed
+261
-15
No files matched your search
@@ -11,7 +11,7 @@ export function getRaceDayCheckAction(item, session) {
|
||||
const view = session?.mode === "track" ? "cars" : "drivers";
|
||||
return { view, label: "nav." + view };
|
||||
}
|
||||
if (["participants", "grid", "transponders", "duplicate_transponders", "lap_window"].includes(item.id)) {
|
||||
if (["participants", "grid", "transponders", "duplicate_transponders", "duplicate_team_members", "lap_window"].includes(item.id)) {
|
||||
const view = session?.mode === "track" ? "events" : "race_setup";
|
||||
return { view, label: "nav." + view };
|
||||
}
|
||||
@@ -32,6 +32,7 @@ function renderPreflightDetail(item, { t, formatLap, escapeHtml }) {
|
||||
: t("race_day.count", { count: item.count || 0 });
|
||||
}
|
||||
if (item.id === "duplicate_transponders" && item.duplicates?.length) return escapeHtml(item.duplicates.join(", "));
|
||||
if (item.id === "duplicate_team_members" && item.duplicateTeamMemberNames?.length) return escapeHtml(item.duplicateTeamMemberNames.join(", "));
|
||||
if (item.id === "grid") return item.notRequired ? t("race_day.not_required") : `${item.count || 0}/${item.expectedCount || 0}`;
|
||||
return t(`race_day.check_${item.level}`);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user