feat(practice): flag suspiciously short laps and remove any lap in one click

Practice laps under 85% of the driver's own median (a likely shortcut)
are flagged: counted, but never a best lap, record or training stat
until approved. Timing and Race Day get a one-click Approve/Remove
panel, overlays show a warning mark, and any lap can be removed or
restored from Timing and Judging with undo.

Also sends judge corrections straight to the server so its hot-results
protection can no longer hold back a correction made right after a
passing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
larssandandClaude Opus 5.5 committed 2026-10-07 19:53:23 +02:00
1 parent 3cc4fa0845
commit 8601954ea2
24 files changed
+556 -60

No files matched your search

+57 -12
View File
@@ -1,4 +1,5 @@
import { sortableTable, sortValuesAttribute } from "./list_sorting.js";
import { listPendingSuspectLaps } from "./suspect_laps_logic.js";
import {
advanceSessionReplay,
buildSessionReplaySnapshot,
@@ -226,9 +227,36 @@ function renderQuickAddPanel(session, deps) {
`;
}
function renderLapActions(passing, rowKey, { t, escapeHtml }) {
const button = (action, label, extra = "") => `<button class="btn btn-mini ${extra}" type="button" data-lap-action="${action}" data-lap-row="${escapeHtml(rowKey)}" data-lap-ts="${Number(passing.timestamp || 0)}">${escapeHtml(t(label))}</button>`;
if (passing.validLap === false) return passing.invalidReason === "manual_invalid" ? button("restore", "timing.lap_restore") : "";
return `${passing.suspect ? button("approve", "suspect.approve") : ""}${button("remove", "timing.lap_remove", "btn-danger")}`;
}
// Practice: suspect laps waiting for a decision, one click each, right above the leaderboard.
export function renderSuspectLapsPanel(session, deps) {
const { t, escapeHtml, formatLap, ensureSessionResult } = deps;
const pending = listPendingSuspectLaps(ensureSessionResult(session.id));
if (!pending.length) return "";
return `
<section class="panel mt-16 suspect-laps-panel" id="suspectLapsPanel">
<div class="panel-header"><div><h3>⚠ ${escapeHtml(t("suspect.title", { count: pending.length }))}</h3><p class="hint">${escapeHtml(t("suspect.hint"))}</p></div></div>
<div class="panel-body suspect-laps-list">
${pending.map((passing) => `
<div class="suspect-lap-row">
<span><strong>${escapeHtml(passing.displayName || passing.driverName || passing.transponder || t("common.unknown_driver"))}</strong> · ${formatLap(passing.lapMs)} · <small>${new Date(passing.timestamp).toLocaleTimeString()}</small></span>
<span class="lap-actions">${renderLapActions(passing, passing.competitorKey, { t, escapeHtml })}</span>
</div>`).join("")}
</div>
</section>`;
}
function renderLeaderboardModal(session, row, deps) {
const { t, escapeHtml, formatLap, formatRaceClock, renderTable, getCompetitorPassings, renderQuickAddActions } = deps;
const passings = getCompetitorPassings(session, row);
// Every lap, removed ones included, so any lap - not just the last - can be removed,
// restored or (a suspect practice lap) approved.
const passings = getCompetitorPassings(session, row, { includeInvalid: true });
let lapNumber = 0;
return `
<div class="modal-overlay" id="leaderboardModalOverlay">
<div class="modal-card">
@@ -268,15 +296,20 @@ function renderLeaderboardModal(session, row, deps) {
${
passings.length
? renderTable(
[t("table.lap"), t("table.time"), t("table.last_lap")],
[t("table.lap"), t("table.time"), t("table.last_lap"), ""],
passings.map(
(passing, index) => `
<tr>
<td>${index + 1}</td>
(passing) => {
const counted = passing.validLap !== false;
if (counted) lapNumber += 1;
return `
<tr class="${counted ? (passing.suspect ? "is-suspect" : "") : "is-removed"}">
<td>${counted ? lapNumber : "–"}</td>
<td>${formatRaceClock(Math.max(0, passing.timestamp - (session.startedAt || passing.timestamp)))}</td>
<td>${formatLap(passing.lapMs)}</td>
<td>${formatLap(passing.lapMs)}${passing.suspect && counted ? ` <span class="suspect-flag">⚠</span>` : ""}${counted ? "" : ` <small>${escapeHtml(t(passing.invalidReason === "manual_invalid" ? "timing.lap_removed" : "timing.invalid_short"))}</small>`}</td>
<td class="lap-actions">${renderLapActions(passing, row.key, { t, escapeHtml })}</td>
</tr>
`
`;
}
)
)
: `<p>${t("timing.no_lap_history")}</p>`
@@ -316,7 +349,7 @@ function renderLeaderboard(rows, deps) {
<tr data-sort-values="${sortValuesAttribute([idx + 1, row.displayName || row.driverName, row.subLabel || row.carName, row.transponder, row.laps, row.resultDisplay, row.lastLapMs || null, row.bestLapMs || null, row.leaderGap || row.gap || null, row.gapAhead || null, row.lapDelta || null, row.lastSplitMs || null, [Number(row.pitStops || 0), Number(row.totalPitMs || 0)]])}" class="${row.invalidPending ? "leaderboard-invalid" : ""}">
<td><span class="pos-pill ${posClass}">${idx + 1}</span></td>
<td>
<div class="table-primary">${escapeHtml(row.displayName || row.driverName)}${row.personalTimeUp ? ` <span class="pill pill-green">🏁 ${t("timing.personal_time_up")}</span>` : ""}</div>
<div class="table-primary">${escapeHtml(row.displayName || row.driverName)}${row.personalTimeUp ? ` <span class="pill pill-green">🏁 ${t("timing.personal_time_up")}</span>` : ""}${row.suspectPending ? ` <span class="suspect-flag" title="${escapeHtml(t("suspect.flag_title"))}">⚠</span>` : ""}</div>
${row.teamId ? `<div class="table-subnote">${t("overlay.active_member")}: ${escapeHtml(formatTeamActiveMemberLabel(row))}</div>` : ""}
${getManualCorrectionSummary(row) ? `<div class="table-subnote">${escapeHtml(getManualCorrectionSummary(row))}</div>` : ""}
${row.invalidPending ? `<div class="table-subnote table-subnote-warn">${escapeHtml(row.invalidLabel)}${row.invalidLapMs ? ` • ${formatLap(row.invalidLapMs)}` : ""}</div>` : ""}
@@ -380,7 +413,7 @@ export function renderTimingView(deps) {
getQuickAddDraft, setQuickAddDraft, getPassingValidationLabel, isCountedPassing, getCompetitorPassings,
getManualCorrectionSummary, formatTeamActiveMemberLabel, formatRaceClock, renderSessionChannelAnalysis,
setLastFinishAnnouncementSessionId, lastOverlayLeaderKeyBySession, lastOverlayTop3BySession, overlayEvents, setOverlayEvents, sessionReplay,
syncTrainingLedger = () => {},
syncTrainingLedger = () => {}, setCompetitorLapStatus = () => false,
} = deps;
const helperDeps = {
@@ -536,6 +569,7 @@ export function renderTimingView(deps) {
</div>
</section>
${active ? renderSuspectLapsPanel(active, { t, escapeHtml, formatLap, ensureSessionResult }) : ""}
<section class="panel mt-16">
<div class="panel-header"><h3>${t("timing.leaderboard")}</h3></div>
<div class="panel-body">
@@ -780,6 +814,12 @@ export function renderTimingView(deps) {
if (session) finishOperationalSession(session);
});
// Remove / restore / approve one lap - from the suspect panel or a driver's lap list.
dom.view.querySelectorAll("[data-lap-action]").forEach((button) => button.addEventListener("click", () => {
const session = getActiveSession();
if (session && setCompetitorLapStatus(session, button.dataset.lapRow, Number(button.dataset.lapTs), button.dataset.lapAction)) renderView();
}));
document.getElementById("resetSession")?.addEventListener("click", () => {
const session = getActiveSession();
if (!session) {
@@ -848,6 +888,7 @@ export function renderJudgingView(deps) {
getPassingValidationLabel, undoJudgingAdjustment, applyCompetitorCorrection, invalidateCompetitorLastLap,
restoreCompetitorLastInvalidLap, renderView, getSelectedJudgeKey, setSelectedJudgeKey,
getJudgingCompetitorFilter, setJudgingCompetitorFilter, getJudgingLogFilter, setJudgingLogFilter,
setCompetitorLapStatus = () => false,
} = deps;
const active = getActiveSession();
@@ -943,13 +984,14 @@ export function renderJudgingView(deps) {
${
selectedPassings.length
? renderTable(
[t("table.lap"), t("table.last_lap"), t("table.status")],
[t("table.lap"), t("table.last_lap"), t("table.status"), ""],
selectedPassings.map(
(passing, index) => `
<tr class="${isCountedPassing(passing) ? "" : "passing-invalid"}">
<tr class="${isCountedPassing(passing) ? (passing.suspect ? "is-suspect" : "") : "passing-invalid"}">
<td>${index + 1}</td>
<td>${formatLap(passing.lapMs)}</td>
<td>${formatLap(passing.lapMs)}${passing.suspect && isCountedPassing(passing) ? ` <span class="suspect-flag">⚠</span>` : ""}</td>
<td>${escapeHtml(getPassingValidationLabel(passing))}</td>
<td class="lap-actions">${renderLapActions(passing, selectedRow.key, { t, escapeHtml })}</td>
</tr>
`
)
@@ -1091,6 +1133,9 @@ export function renderJudgingView(deps) {
invalidateCompetitorLastLap(active, selectedRow);
renderJudgingView(deps);
});
dom.view.querySelectorAll("[data-lap-action]").forEach((button) => button.addEventListener("click", () => {
if (setCompetitorLapStatus(active, button.dataset.lapRow, Number(button.dataset.lapTs), button.dataset.lapAction)) renderJudgingView(deps);
}));
document.getElementById("judgeRestore")?.addEventListener("click", () => {
restoreCompetitorLastInvalidLap(active, selectedRow);
renderJudgingView(deps);