fix(race-setup): ask before deleting a race or a session (1.54.1)

This commit is contained in:
larssand committed 2026-11-02 08:48:37 +01:00
1 parent d0248b1960
commit 8b625c3d64
7 files changed
+27 -3

No files matched your search

+6
View File
@@ -8,6 +8,12 @@ The application version is maintained in `package.json` and displayed in the adm
No changes recorded yet. No changes recorded yet.
## 1.54.1 - 2026-11-02
### Fixed
- Deleting a race (✕ in Race Setup) or a session (⋯ → Delete) now asks first, naming it and how many sessions with laps go with it. It used to delete at once, so a stray click could remove a whole race.
## 1.54.0 - 2026-11-02 ## 1.54.0 - 2026-11-02
### Changed ### Changed
+2 -2
View File
@@ -1,12 +1,12 @@
{ {
"name": "rc-racecore", "name": "rc-racecore",
"version": "1.54.0", "version": "1.54.1",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "rc-racecore", "name": "rc-racecore",
"version": "1.54.0", "version": "1.54.1",
"hasInstallScript": true, "hasInstallScript": true,
"dependencies": { "dependencies": {
"better-sqlite3": "^12.11.1", "better-sqlite3": "^12.11.1",
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "rc-racecore", "name": "rc-racecore",
"version": "1.54.0", "version": "1.54.1",
"private": true, "private": true,
"description": "RC RaceCore live timing and race control with AMMC ingest and SQLite persistence", "description": "RC RaceCore live timing and race control with AMMC ingest and SQLite persistence",
"engines": { "engines": {
+4
View File
@@ -2228,6 +2228,8 @@ const TRANSLATIONS = {
"events.session_max_cars_hint": "Sätt gräns om just den sessionen bara ska ha ett visst antal bilar.", "events.session_max_cars_hint": "Sätt gräns om just den sessionen bara ska ha ett visst antal bilar.",
"events.edit_session_help": "Ändra sessionens namn, typ, tid och seed-/startinställningar här.", "events.edit_session_help": "Ändra sessionens namn, typ, tid och seed-/startinställningar här.",
"events.set_active": "Sätt aktiv", "events.set_active": "Sätt aktiv",
"events.delete_race_confirm": "Ta bort racet \"{name}\"?\n\nDet tar bort {sessions} sessioner, varav {run} med körda varv. Det går inte att ångra.",
"events.delete_session_confirm": "Ta bort \"{name}\"? Heatets varv och resultat försvinner också. Det går inte att ångra.",
"events.more_actions": "Fler val: utskrift, export, grid, ta bort", "events.more_actions": "Fler val: utskrift, export, grid, ta bort",
"events.step_practice": "Träning / seedning", "events.step_practice": "Träning / seedning",
"events.step_qual_round": "Kval omgång {round}", "events.step_qual_round": "Kval omgång {round}",
@@ -4185,6 +4187,8 @@ const TRANSLATIONS = {
"events.session_max_cars_hint": "Set a limit if this session should only allow a certain number of cars.", "events.session_max_cars_hint": "Set a limit if this session should only allow a certain number of cars.",
"events.edit_session_help": "Edit the session name, type, timing and seed/start settings here.", "events.edit_session_help": "Edit the session name, type, timing and seed/start settings here.",
"events.set_active": "Set Active", "events.set_active": "Set Active",
"events.delete_race_confirm": "Delete the race \"{name}\"?\n\nThis deletes {sessions} sessions, {run} of them with laps run. It cannot be undone.",
"events.delete_session_confirm": "Delete \"{name}\"? Its laps and result are deleted too. It cannot be undone.",
"events.more_actions": "More: print, export, grid, delete", "events.more_actions": "More: print, export, grid, delete",
"events.step_practice": "Practice / seeding", "events.step_practice": "Practice / seeding",
"events.step_qual_round": "Qualifying round {round}", "events.step_qual_round": "Qualifying round {round}",
+1
View File
@@ -371,6 +371,7 @@ export function renderEventManagerView(context) {
})); }));
document.getElementById(`session-delete-${s.id}`)?.addEventListener("click", () => { document.getElementById(`session-delete-${s.id}`)?.addEventListener("click", () => {
if (!window.confirm(t("events.delete_session_confirm", { name: s.name }))) return;
state.sessions = state.sessions.filter((x) => x.id !== s.id); state.sessions = state.sessions.filter((x) => x.id !== s.id);
delete state.resultsBySession[s.id]; delete state.resultsBySession[s.id];
if (state.activeSessionId === s.id) { if (state.activeSessionId === s.id) {
+3
View File
@@ -292,6 +292,9 @@ export function renderEventWorkspaceView(context) {
document.getElementById(`event-delete-${e.id}`)?.addEventListener("click", () => { document.getElementById(`event-delete-${e.id}`)?.addEventListener("click", () => {
const sessionIds = getSessionsForEvent(e.id).map((s) => s.id); const sessionIds = getSessionsForEvent(e.id).map((s) => s.id);
// Deleting takes every heat and lap with it, and the row is gone at once: always ask.
const run = sessionIds.filter((id) => (state.resultsBySession[id]?.passings || []).length).length;
if (!window.confirm(t("events.delete_race_confirm", { name: e.name, sessions: sessionIds.length, run }))) return;
state.events = state.events.filter((x) => x.id !== e.id); state.events = state.events.filter((x) => x.id !== e.id);
state.sessions = state.sessions.filter((x) => x.eventId !== e.id); state.sessions = state.sessions.filter((x) => x.eventId !== e.id);
sessionIds.forEach((id) => delete state.resultsBySession[id]); sessionIds.forEach((id) => delete state.resultsBySession[id]);
+10
View File
@@ -101,6 +101,16 @@ export async function runDayScheduleSmoke({ evaluate, navigate, savedState, wait
await evaluate(`document.getElementById("dayToggleDone").click()`); await evaluate(`document.getElementById("dayToggleDone").click()`);
await waitFor(async () => (await rowIds()).includes("ds_4wd_q1"), "and shown again on request"); await waitFor(async () => (await rowIds()).includes("ds_4wd_q1"), "and shown again on request");
console.log("PASS today's schedule folds run heats into one line and marks the next heat"); console.log("PASS today's schedule folds run heats into one line and marks the next heat");
// Deleting a race always asks first (the harness answers OK).
await patchState({ events: [...(await savedState()).events, { id: "ds_delete_me", name: "DS Delete Me", date: today, mode: "race", raceConfig: {} }] });
await navigate("race_setup", "raceWizardStepForm");
const asked = dialogs.length;
await evaluate(`document.getElementById("event-delete-ds_delete_me").click()`);
await waitFor(async () => !(await savedState()).events.some((event) => event.id === "ds_delete_me"), "the race is deleted after OK");
assert.equal(dialogs.length, asked + 1, "a question was asked");
assert.match(dialogs.at(-1).message, /DS Delete Me/);
console.log("PASS deleting a race asks first");
} finally { } finally {
const current = await savedState(); const current = await savedState();
await patchState({ await patchState({