From da20a7e97820be42bb90f000b2f299bf125a9c00 Mon Sep 17 00:00:00 2001 From: larssand Date: Fri, 13 Nov 2026 16:08:29 +0100 Subject: [PATCH] =?UTF-8?q?fix(pdf):=20export=20no=20longer=20fails=20on?= =?UTF-8?q?=20names=20with=20=C3=A5/=C3=A4/=C3=B6=20or=20emoji=20in=20the?= =?UTF-8?q?=20file=20name=20(1.89.19)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 6 ++++++ package-lock.json | 4 ++-- package.json | 2 +- server.js | 11 ++++++++++- tests/server_persistence.integration.test.js | 10 ++++++++++ 5 files changed, 29 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 50a709b..d987d09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,12 @@ The application version is maintained in `package.json` and displayed in the adm No changes recorded yet. +## 1.89.19 - 2026-11-13 + +### Fixed + +- PDF export failed with "Invalid character in header content" when the race, heat or series name had å/ä/ö, an emoji or other non-ASCII characters. The file keeps its real name. + ## 1.89.18 - 2026-11-13 ### Added diff --git a/package-lock.json b/package-lock.json index 552f29b..f5c141b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "rc-racecore", - "version": "1.89.18", + "version": "1.89.19", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "rc-racecore", - "version": "1.89.18", + "version": "1.89.19", "hasInstallScript": true, "dependencies": { "better-sqlite3": "^12.11.1", diff --git a/package.json b/package.json index 1c65381..95c1ba7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rc-racecore", - "version": "1.89.18", + "version": "1.89.19", "private": true, "description": "RC RaceCore live timing and race control with AMMC ingest and SQLite persistence", "engines": { diff --git a/server.js b/server.js index 8aa575a..ec63c72 100644 --- a/server.js +++ b/server.js @@ -665,7 +665,7 @@ app.post("/api/export/pdf", (req, res) => { const payload = normalizePdfExportPayload(req.body || {}); const pdf = buildStyledPdf(payload); res.setHeader("Content-Type", "application/pdf"); - res.setHeader("Content-Disposition", `attachment; filename="${payload.filename}"`); + res.setHeader("Content-Disposition", attachmentDisposition(payload.filename)); res.send(pdf); } catch (error) { res.status(400).json({ error: error instanceof Error ? error.message : String(error) }); @@ -898,6 +898,15 @@ function readStoredAppState() { return { state: JSON.parse(row.state_json), updatedAt: row.updated_at }; } +// A header may only hold plain ASCII: a race named "Höstcupen" or "Open #Test2 🏁" made the +// export fail with "Invalid character in header content". ASCII fallback for old clients, +// plus the real name encoded (RFC 6266/5987) for every current browser. +function attachmentDisposition(filename) { + const name = String(filename || "export.pdf"); + const ascii = name.normalize("NFKD").replace(/[\u0300-\u036f]/g, "").replace(/[^\x20-\x7e]/gu, "_").replace(/["\\]/g, "_") || "export.pdf"; + return `attachment; filename="${ascii}"; filename*=UTF-8''${encodeURIComponent(name)}`; +} + function normalizePdfExportPayload(input = {}) { const title = String(input.title || "RC RaceCore").trim(); const subtitle = String(input.subtitle || "").trim(); diff --git a/tests/server_persistence.integration.test.js b/tests/server_persistence.integration.test.js index 16856f5..881b358 100644 --- a/tests/server_persistence.integration.test.js +++ b/tests/server_persistence.integration.test.js @@ -517,6 +517,16 @@ test("PDF export renders Swedish åäö/ÅÄÖ correctly instead of mojibake", { }); assert.equal(response.status, 200); assert.equal(response.headers.get("content-type"), "application/pdf"); + // A file name with å/ä/ö, # or an emoji may not break the header ("Invalid character in header content"). + const named = await fetch(`${baseUrl}/api/export/pdf`, { + method: "POST", + headers: { "Content-Type": "application/json" }, + body: JSON.stringify({ title: "x", filename: "Höstcupen_Open_#Test2_🏁_A-final.pdf", sections: [{ title: "x", headers: ["a"], rows: [["b"]] }] }), + }); + assert.equal(named.status, 200); + const disposition = named.headers.get("content-disposition"); + assert.match(disposition, /filename="Hostcupen_Open_#Test2___A-final\.pdf"/); + assert.match(disposition, /filename\*=UTF-8''H%C3%B6stcupen/); const pdfBuffer = Buffer.from(await response.arrayBuffer()); // The font must declare WinAnsiEncoding - without it a PDF viewer falls back to a standard